-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][build] Support custom image and label names #22703
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the comment for the latest-version-image name
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22703 +/- ##
============================================
- Coverage 73.57% 73.17% -0.41%
+ Complexity 32624 32531 -93
============================================
Files 1877 1889 +12
Lines 139502 141392 +1890
Branches 15299 15516 +217
============================================
+ Hits 102638 103460 +822
- Misses 28908 29928 +1020
- Partials 7956 8004 +48
Flags with carried forward coverage won't be shown. Click here to find out more. |
@lhotari CI has been passed. |
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Motivation
When pushing pulsar and pulsar-all to a custom repository, I don't want to use the original name. If we can support custom image and label names, it will reduce the workload of copying.
Modifications
docker.image
property to define the image name, default topulsar
docker.tag
property to define the tag name, default tolatest
docker.image
anddocker.tag
to the pulsar, pulsar-all, java-test-image, latest-version-imageDocumentation
doc
doc-required
doc-not-needed
doc-complete