Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [test] Add a test to guarantee the TNX topics will not be replicated #22721

Merged

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented May 15, 2024

Motivation & Modifications

  • Add a test to guarantee the TNX system topics will not be replicated
  • Add a test to guarantee the messages that are in an ongoing TXN will not be replicated.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.18%. Comparing base (bbc6224) to head (67871c2).
Report is 274 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22721      +/-   ##
============================================
- Coverage     73.57%   73.18%   -0.39%     
+ Complexity    32624     2506   -30118     
============================================
  Files          1877     1889      +12     
  Lines        139502   141385    +1883     
  Branches      15299    15514     +215     
============================================
+ Hits         102638   103478     +840     
- Misses        28908    29910    +1002     
- Partials       7956     7997      +41     
Flag Coverage Δ
inttests 27.43% <ø> (+2.84%) ⬆️
systests 24.73% <ø> (+0.41%) ⬆️
unittests 72.20% <ø> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 352 files with indirect coverage changes

@dao-jun dao-jun merged commit 4e132d3 into apache:master May 16, 2024
50 checks passed
poorbarcode added a commit that referenced this pull request May 20, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 31, 2024
…eplicated (apache#22721)

(cherry picked from commit 4e132d3)
(cherry picked from commit b11ab69)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2024
…eplicated (apache#22721)

(cherry picked from commit 4e132d3)
(cherry picked from commit b11ab69)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2024
…eplicated (apache#22721)

(cherry picked from commit 4e132d3)
(cherry picked from commit b11ab69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants