Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LEAK: HAProxyMessage.release() was not called before it's garbage-collected #7025

Merged
merged 30 commits into from
Jul 14, 2023
Merged

Fix LEAK: HAProxyMessage.release() was not called before it's garbage-collected #7025

merged 30 commits into from
Jul 14, 2023

Conversation

dingshuangxi888
Copy link
Contributor

@dingshuangxi888 dingshuangxi888 commented Jul 14, 2023

Which Issue(s) This PR Fixes

Fixes #7024

Brief Description

HAProxyMessage.release() should be called after it is used.
You can find the cause and solution through the following link: netty/netty#9420

How Did You Test This Change?

Create a large client for test the message sending, and observe the logs for the errors.

徒钟 and others added 30 commits June 7, 2023 13:47
Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit 70a66ed into apache:develop Jul 14, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] LEAK: HAProxyMessage.release() was not called before it's garbage-collected
2 participants