-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LEAK: HAProxyMessage.release() was not called before it's garbage-collected #7025
Merged
xdkxlk
merged 30 commits into
apache:develop
from
dingshuangxi888:hotfix/fix_haproxy_message_release
Jul 14, 2023
Merged
Fix LEAK: HAProxyMessage.release() was not called before it's garbage-collected #7025
xdkxlk
merged 30 commits into
apache:develop
from
dingshuangxi888:hotfix/fix_haproxy_message_release
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity of ProtocolNegotiator
…ity of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
xdkxlk
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7024
Brief Description
HAProxyMessage.release() should be called after it is used.
You can find the cause and solution through the following link: netty/netty#9420
How Did You Test This Change?
Create a large client for test the message sending, and observe the logs for the errors.