Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7697]Fix can't open controller metricsExporter. #7705

Merged
merged 1 commit into from Dec 28, 2023

Conversation

baijun44
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7697

Brief Description

add two set methods for field metricsExporterType in order to make config 'metricsExporterType' work.

How Did You Test This Change?

1.add a config "metricsExporterType = PROM" for controller
2.open localhost:5557/metrics and can get metrics info.

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (59e8f9b) 43.17% compared to head (454a3aa) 43.14%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...a/org/apache/rocketmq/common/ControllerConfig.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7705      +/-   ##
=============================================
- Coverage      43.17%   43.14%   -0.03%     
+ Complexity      9812     9801      -11     
=============================================
  Files           1165     1165              
  Lines          84542    84546       +4     
  Branches       10979    10979              
=============================================
- Hits           36502    36480      -22     
- Misses         43497    43521      +24     
- Partials        4543     4545       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 9e4fd0e into apache:develop Dec 28, 2023
9 of 10 checks passed
@iamgd67
Copy link
Contributor

iamgd67 commented Mar 20, 2024

dumplicate to #7492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] can't open controller metricsExporter
4 participants