[ISSUE #8062] feat: Add virtual thread support for consumers #8063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
vtSupport
branch
4 times, most recently
from
3d12a39
to
9006d53
Compare
Merged
He-Pin
commented
Apr 25, 2024
| this.consumeExecutor = new ThreadPoolExecutor( | ||
| this.defaultMQPushConsumer.getConsumeThreadMin(), | ||
| this.defaultMQPushConsumer.getConsumeThreadMax(), | ||
| 1000 * 60, | ||
| TimeUnit.MILLISECONDS, | ||
| this.consumeRequestQueue, | ||
| new ThreadFactoryImpl("ConsumeMessageThread_" + consumerGroupTag)); | ||
| new ThreadFactoryImpl(threadNamePrefix, false, null, PREFER_VIRTUAL)); |
There was a problem hiding this comment.
This is not using the one task one executor pattern for Virtual Thread, this works well too, otherwise, needs much adoption.
cserwen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8062
Brief Description
"rocketmq.client.consumer.virtualThread"default tofalsetrueand the Virtual thread is enabled, Make use of the virtual thread.How Did You Test This Change?
with unit tests