Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8061] Fix npe in netty remoting client #8064

Merged
merged 43 commits into from May 14, 2024

Conversation

fujian-zfj
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8061

Brief Description

I found a npe bug in method getAndCreateChannel.

It may caused by 'getAndCreateChannelAsync(addr).awaitUninterruptibly()' in method getAndCreateChannel.

Since channelFuture has got from getAndCreateChannelAsync and is judged not null, why not use channelFuture instead of getAndCreateChannelAsync again?

How Did You Test This Change?

fujian-zfj and others added 30 commits November 30, 2021 20:19
@cserwen cserwen changed the title Npe in netty remoting client [ISSUE #8061] Fix npe in netty remoting client Apr 28, 2024
@cserwen
Copy link
Member

cserwen commented May 8, 2024

Rebase develop branch to fix some errors of ci. @fujian-zfj

@RongtongJin
Copy link
Contributor

Hi @fujian-zfj you need to merge the develop branch to include the latest unit test fixes.

@fujian-zfj
Copy link
Contributor Author

Hi @fujian-zfj you need to merge the develop branch to include the latest unit test fixes.
OK

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.88%. Comparing base (159a603) to head (2e0bae0).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8064      +/-   ##
=============================================
- Coverage      42.91%   42.88%   -0.04%     
+ Complexity     10382    10374       -8     
=============================================
  Files           1270     1270              
  Lines          88694    88694              
  Branches       11401    11401              
=============================================
- Hits           38066    38035      -31     
- Misses         45935    45957      +22     
- Partials        4693     4702       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins merged commit 03b16aa into apache:develop May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NPE of getAndCreateChannel in NettyRemotingClient
6 participants