New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8061] Fix npe in netty remoting client #8064
[ISSUE #8061] Fix npe in netty remoting client #8064
Conversation
Rebase develop branch to fix some errors of ci. @fujian-zfj |
Hi @fujian-zfj you need to merge the develop branch to include the latest unit test fixes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8064 +/- ##
=============================================
- Coverage 42.91% 42.88% -0.04%
+ Complexity 10382 10374 -8
=============================================
Files 1270 1270
Lines 88694 88694
Branches 11401 11401
=============================================
- Hits 38066 38035 -31
- Misses 45935 45957 +22
- Partials 4693 4702 +9 ☔ View full report in Codecov by Sentry. |
Which Issue(s) This PR Fixes
Fixes #8061
Brief Description
I found a npe bug in method getAndCreateChannel.
It may caused by 'getAndCreateChannelAsync(addr).awaitUninterruptibly()' in method getAndCreateChannel.
Since channelFuture has got from getAndCreateChannelAsync and is judged not null, why not use channelFuture instead of getAndCreateChannelAsync again?
How Did You Test This Change?