Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8150] Remove consuming boolean flag in ProcessQueue class #8151

Closed
wants to merge 1 commit into from

Conversation

miles-ton
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8150

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.89%. Comparing base (2fdafd2) to head (e211635).

Files Patch % Lines
...he/rocketmq/client/impl/consumer/ProcessQueue.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8151      +/-   ##
=============================================
- Coverage      42.95%   42.89%   -0.07%     
+ Complexity     10384    10365      -19     
=============================================
  Files           1270     1270              
  Lines          88690    88686       -4     
  Branches       11401    11400       -1     
=============================================
- Hits           38097    38038      -59     
- Misses         45899    45945      +46     
- Partials        4694     4703       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consuming flag is actually used inside ProcessQueue class which is not consistent with your description.

@miles-ton miles-ton closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] remove unused boolean flag
3 participants