Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Zeta] Move SaveMode behavior to master #6843

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR move savemode logic into master node.
Mainly for two purposes:

  1. Maintain the same behavior as the Rest submit job. Before this, the SaveMode logic of Rest mode was executed on the master, but the client mode was executed on the client side.
  2. Prepare for related SaveMode event processing. Based on purpose 1, we can ensure consistent behavior of SaveMode related events.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X changed the title [Improve][Zeta] Move execute SaveMode on master [Improve][Zeta] Move SaveMode behavior to master May 11, 2024
for (LogicalEdge edge : edges) {
out.writeObject(edge);
}

out.writeInt(saveModeList.size());
for (SupportSaveMode saveMode : saveModeList) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider the DataSerializable of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, the current SupportSaveMode declarations are all on the SeaTunnelSink implementation class, and all SeaTunnelSinks are serializable by default. It is also engine-independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants