Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Core] Config variable substitution inconsistent #6847

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

xuqi1633
Copy link

@xuqi1633 xuqi1633 commented May 13, 2024

Purpose of this pull request

#6840

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@xuqi1633
Copy link
Author

@liunaijie i have updated test variable

@liunaijie
Copy link
Contributor

@liunaijie i have updated test variable

Please also update the config. add Assert sink to check the value are expected.

@Hisoka-X Hisoka-X added First-time contributor First-time contributor bugfix labels May 15, 2024
@Hisoka-X Hisoka-X changed the title [Fix-6840] Config variable substitution inconsistent [Fix][Core] Config variable substitution inconsistent May 15, 2024
@Hisoka-X Hisoka-X added this to the 2.3.6 milestone May 15, 2024
@xuqi1633
Copy link
Author

@liunaijie is that so?

@liunaijie
Copy link
Contributor

image @xuqi1633 the test failed, please check.

@liunaijie
Copy link
Contributor

liunaijie commented May 15, 2024

image

the change not work, and please also update the other starter script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix First-time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants