Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code format optimization and remove unnecessary mock. #15233

Merged
merged 1 commit into from Feb 2, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -26,7 +26,6 @@
import org.apache.shardingsphere.data.pipeline.core.datasource.PipelineDataSourceManager;
import org.apache.shardingsphere.data.pipeline.core.exception.PipelineJobPrepareFailedException;
import org.apache.shardingsphere.data.pipeline.core.prepare.datasource.PrepareTargetTablesParameter;
import org.apache.shardingsphere.driver.config.datasource.ShardingSpherePipelineDataSourceCreator;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand All @@ -44,7 +43,6 @@
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

// FIX test cases
@RunWith(MockitoJUnitRunner.class)
public final class MySQLDataSourcePreparerTest {

Expand Down Expand Up @@ -72,9 +70,6 @@ public final class MySQLDataSourcePreparerTest {
@Mock
private PipelineDataSourceWrapper targetDataSourceWrapper;

@Mock
private ShardingSpherePipelineDataSourceCreator mockShardingSpherePipelineDataSourceCreator;

@Before
public void setUp() throws SQLException {
PipelineDataSourceManager mockPipelineDataSourceManager = mock(PipelineDataSourceManager.class);
Expand Down Expand Up @@ -116,6 +111,5 @@ public void assertThrowPrepareFailedException() throws SQLException {
MySQLDataSourcePreparer mySQLDataSourcePreparer = new MySQLDataSourcePreparer();
mySQLDataSourcePreparer.prepareTargetTables(prepareTargetTablesParameter);
}

}
}