Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated nameResolverFactory method. #7132

Merged
merged 2 commits into from Jun 18, 2021
Merged

Conversation

wu-sheng
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Remove deprecated gRPC method, io.grpc.ManagedChannelBuilder#nameResolverFactory. See gRPC-java 7133 for more details.

@wu-sheng wu-sheng added agent Language agent related. enhancement Enhancement on performance or codes labels Jun 18, 2021
@wu-sheng wu-sheng added this to the 8.7.0 milestone Jun 18, 2021
@wu-sheng wu-sheng requested a review from kezhenxu94 June 18, 2021 09:12
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #7132 (b63d506) into master (002f4c2) will decrease coverage by 9.47%.
The diff coverage is 46.37%.

❗ Current head b63d506 differs from pull request most recent head 75fb485. Consider uploading reports for the commit 75fb485 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7132      +/-   ##
============================================
- Coverage     50.35%   40.88%   -9.48%     
- Complexity     2692     3200     +508     
============================================
  Files           740     1024     +284     
  Lines         18265    25932    +7667     
  Branches       1766     2545     +779     
============================================
+ Hits           9198    10603    +1405     
- Misses         8337    14421    +6084     
- Partials        730      908     +178     
Impacted Files Coverage Δ
...walking/apm/commons/datacarrier/buffer/Buffer.java 71.42% <ø> (+71.42%) ⬆️
...commons/datacarrier/common/AtomicRangeInteger.java 50.00% <ø> (ø)
...datacarrier/consumer/MultipleChannelsConsumer.java 77.08% <ø> (ø)
...tacarrier/partition/ProducerThreadPartitioner.java 0.00% <ø> (ø)
.../apache/skywalking/apm/util/ConfigInitializer.java 64.04% <0.00%> (+8.48%) ⬆️
.../commands/executor/ProfileTaskCommandExecutor.java 7.69% <0.00%> (ø)
.../apm/agent/core/context/ids/GlobalIdGenerator.java 68.18% <0.00%> (+5.68%) ⬆️
...ent/core/context/status/ExceptionCheckContext.java 0.00% <0.00%> (ø)
...alking/apm/agent/core/context/tag/AbstractTag.java 35.00% <0.00%> (-28.64%) ⬇️
.../agent/core/context/trace/AbstractTracingSpan.java 39.09% <0.00%> (-1.48%) ⬇️
... and 864 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4698681...75fb485. Read the comment docs.

@wu-sheng wu-sheng merged commit e21cb19 into master Jun 18, 2021
@wu-sheng wu-sheng deleted the remove-deprecated branch June 18, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. enhancement Enhancement on performance or codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants