[SPARK-33285][CORE][SQL] Fix deprecated compilation warnings of "Auto-application to () is deprecated" in Scala 2.13

[LuciferYang]

What changes were proposed in this pull request?

The purpose of this pr is to partial resolve SPARK-33285.

Auto-application is dropped in Scala 3 and deprecated in 2.13.3 (scala/scala#8833) now. So we should add the parens when accessed empty-paren method.

For example, if definition as follows:

Class Foo {
   def bar(): Unit = {}
}
val foo = new Foo

foo.bar() is recommend , not foo.bar. So the main change of this pr is only add the parens where needed.

Why are the changes needed?

eliminate compilation warnings in Scala 2.13

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass the Jenkins or GitHub Action

[LuciferYang]

cc @srowen this is the first part to fix this compilation warnings, if it's too big, I can split multiple small prs.

[SparkQA]

Test build #130567 has finished for PR 30234 at commit eb84d5e.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Hoo boy that is a lot of code to touch. It sounds like eventually it has to happen for Scala 3 and avoids some deprecation noise. I'm not against it though as usual there is a minor concern about making patches harder to back port from 3.1 to 3.0 because of merge conflicts.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35168/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35168/

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35169/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35169/

[dongjoon-hyun]

@LuciferYang .
After this PR, do we have a way to prevent this compilation warnings?

[SparkQA]

Test build #130568 has finished for PR 30234 at commit dfe1a98.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

Thank you so much for this PR, @LuciferYang .
However, shall we postpone this until Scala 2.13 becomes the default Scala version in Apache Spark?

[LuciferYang]

@dongjoon-hyun

After this PR, do we have a way to prevent this compilation warnings?

It seems that there is no such way now.

However, shall we postpone this until Scala 2.13 becomes the default Scala version in Apache Spark?

Fixed this problem only because there are too many compilation warnings about this and it is compatible with Scala 2.12, and I agree with your suggestion

[LuciferYang]

After this PR, do we have a way to prevent this compilation warnings?

Let me take a look at this problem. Maybe we can change the alarm level of the compiler or check-style plugin by modify some configuration

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35291/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35291/

[SparkQA]

Test build #130680 has finished for PR 30234 at commit 8881355.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[LuciferYang]

@dongjoon-hyun It seems that except for RDD.isEmpty has been fixed.

[dongjoon-hyun]

Sorry, but what do you mean?

It seems that except for RDD.isEmpty has been fixed.

[LuciferYang]

seems all case has been fixed except for RDD.isEmpty relevant case

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35869/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35869/

[SparkQA]

Test build #131266 has finished for PR 30234 at commit 9284fdc.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35945/

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35947/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35945/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35947/

[SparkQA]

Test build #131341 has finished for PR 30234 at commit d8f1db0.

• This patch fails Spark unit tests.
• This patch does not merge cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #131343 has finished for PR 30234 at commit 176d8fd.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class ExecutorSource(
• implicit class MetadataColumnsHelper(metadata: Array[MetadataColumn])

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35957/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35957/

[SparkQA]

Test build #131353 has finished for PR 30234 at commit 1a2b123.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37366/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37366/

[SparkQA]

Test build #132764 has finished for PR 30234 at commit 4253839.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[LuciferYang]

Spark SPARK-33775 add some Scalac config to Suppress compilation warnings, no need to fix this now, close it first