[SPARK-42242][BUILD] Upgrade snappy-java to 1.1.9.1

[dongjoon-hyun]

What changes were proposed in this pull request?

This PR aims to upgrade snappy-java to 1.1.9.1.

Why are the changes needed?

This version has the following bug fixes.

• Use original compressed and uncompressed buffer's position (Use original compressed and uncompressed buffer's position xerial/snappy-java#293)
• Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (#302 Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) xerial/snappy-java#303)
• Avoid explicit class name in throw_exception (Avoid explicit class name in throw_exception xerial/snappy-java#291)

Here is the full release note.

• https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
• https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

[dongjoon-hyun]

Hi, @viirya . Could you review this? This includes your two patches.

[viirya]

Thanks @dongjoon-hyun . Pending CI.

[dongjoon-hyun]

Thank you, @viirya . Yes, pending CI!

[dongjoon-hyun]

Oh...

java.lang.NoSuchMethodError: java.nio.ByteBuffer.limit(I)Ljava/nio/ByteBuffer;
	at org.xerial.snappy.Snappy.compress(Snappy.java:157)

[dongjoon-hyun]

It seems that snappy-java is published via Java 11. I converted this PR as a draft for now.

• https://github.com/xerial/snappy-java/actions/runs/4040266239/jobs/6945753237

[dongjoon-hyun]

Sorry, @viirya and @HyukjinKwon . I will check the situation more.

[LuciferYang]

+1, LGTM

[LuciferYang]

https://github.com/xerial/snappy-java/blob/master/build.sbt#L30

Interesting. It seems that the compilation target is still Java 8...

[dongjoon-hyun]

It's insufficient, @LuciferYang . The runtimeClass (rt.jar) is required during building. Otherwise, Java 11 assumes Java 11 rt.jar.

[srowen]

Looks like that overload isn't even in Java 11; I see it in Java 14: https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/nio/ByteBuffer.html#limit(int)
Yeah, this is not a question of which JVM you target, but of using methods not found in Java 8.

[dongjoon-hyun]

Ya, thank you, @srowen .

[LuciferYang]

https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

@dongjoon-hyun We can try to upgrade 1.1.9.1 to solve this issue

[dongjoon-hyun]

Thank you so much!

[LuciferYang]

It should not be released to the central repository yet. We need to wait for a while

[dongjoon-hyun]

Yes, it seems to be. I'll wait~

[ERROR] Failed to execute goal on project spark-core_2.12: Could not resolve dependencies for project org.apache.spark:spark-core_2.12:jar:spark-185468:
Could not find artifact org.xerial.snappy:snappy-java:jar:1.1.9.1 in gcs-maven-central-mirror (https://maven-central.storage-download.googleapis.com/maven2/) -> [Help 1]

[dongjoon-hyun]

Thank you again, @viirya .

[dongjoon-hyun]

Thank you, @LuciferYang .

[dongjoon-hyun]

All tests passed. Merged to master/3.4.
Thank you, @viirya , @HyukjinKwon , @LuciferYang , @srowen .