Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43832][BUILD] Upgrade Scala to 2.12.18 #41627

Closed
wants to merge 3 commits into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jun 16, 2023

What changes were proposed in this pull request?

This PR aims to upgrade Scala to 2.12.18

Why are the changes needed?

This release adds support for JDK 20 and 21:

The full release notes as follows:

Does this PR introduce any user-facing change?

Yes, this is a Scala version change.

How was this patch tested?

Existing Test

pom.xml Show resolved Hide resolved
@LuciferYang LuciferYang marked this pull request as draft June 16, 2023 13:15
@LuciferYang
Copy link
Contributor Author

Test first

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#41624 is merged. Please rebase to master branch.

@LuciferYang
Copy link
Contributor Author

rebased, will update pr description later

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Jun 17, 2023

need fix #41640 first and rebase

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review June 18, 2023 04:07
@dongjoon-hyun
Copy link
Member

#41640 is fixed and this PR passes the CIs.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun

czxm pushed a commit to czxm/spark that referenced this pull request Jun 19, 2023
### What changes were proposed in this pull request?
This PR aims to upgrade Scala to 2.12.18
- https://www.scala-lang.org/news/2.12.18

### Why are the changes needed?
This release adds support for JDK 20 and 21:
- scala/scala#10185
- scala/scala#10362
- scala/scala#10397
- scala/scala#10400

The full release notes as follows:

- https://github.com/scala/scala/releases/tag/v2.12.18

### Does this PR introduce _any_ user-facing change?
Yes, this is a Scala version change.

### How was this patch tested?
Existing Test

Closes apache#41627 from LuciferYang/SPARK-43832.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants