Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44421][FOLLOWUP] Fix doc test in SparkThrowableSuite #42263

Conversation

juliuszsompolski
Copy link
Contributor

@juliuszsompolski juliuszsompolski commented Aug 1, 2023

What changes were proposed in this pull request?

Forgot to git add the file after regenerating docs.

Why are the changes needed?

Fix docs and reenable test.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually testing SparkThrowableSuite works in both master and branch-3.5.

@github-actions github-actions bot added the CORE label Aug 1, 2023
@LuciferYang
Copy link
Contributor

@juliuszsompolski
Copy link
Contributor Author

@LuciferYang yeah... but locally I get...
image

Let me take a closer look...

@juliuszsompolski
Copy link
Contributor Author

CI has:

2023-08-01T13:00:13.6907733Z �[31m- Error classes match with document *** FAILED *** (42 milliseconds)�[0m�[0m
2023-08-01T13:00:13.6920537Z �[31m  "[---�[0m�[0m
2023-08-01T13:00:13.6923895Z �[31m  layout: global�[0m�[0m
2023-08-01T13:00:13.6929769Z �[31m  title: INVALID_CURSOR error class�[0m�[0m
2023-08-01T13:00:13.6935351Z �[31m  displayTitle: INVALID_CURSOR error class�[0m�[0m
2023-08-01T13:00:13.6942001Z �[31m  license: |�[0m�[0m
2023-08-01T13:00:13.6942716Z �[31m    Licensed to the Apache Software Foundation (ASF) under one or more�[0m�[0m
2023-08-01T13:00:13.6945884Z �[31m    contributor license agreements.  See the NOTICE file distributed with�[0m�[0m
2023-08-01T13:00:13.6957310Z �[31m    this work for additional information regarding copyright ownership.�[0m�[0m
2023-08-01T13:00:13.6960819Z �[31m    The ASF licenses this file to You under the Apache License, Version 2.0�[0m�[0m
2023-08-01T13:00:13.6966067Z �[31m    (the "License"); you may not use this file except in compliance with�[0m�[0m
2023-08-01T13:00:13.6967872Z �[31m    the License.  You may obtain a copy of the License at�[0m�[0m
2023-08-01T13:00:13.6981484Z   �[0m
2023-08-01T13:00:13.6982411Z �[31m       http://www.apache.org/licenses/LICENSE-2.0�[0m�[0m
2023-08-01T13:00:13.6985767Z   �[0m
2023-08-01T13:00:13.6986516Z �[31m    Unless required by applicable law or agreed to in writing, software�[0m�[0m
2023-08-01T13:00:13.6992002Z �[31m    distributed under the License is distributed on an "AS IS" BASIS,�[0m�[0m
2023-08-01T13:00:13.7003109Z �[31m    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.�[0m�[0m
2023-08-01T13:00:13.7004137Z �[31m    See the License for the specific language governing permissions and�[0m�[0m
2023-08-01T13:00:13.7004808Z �[31m    limitations under the License.�[0m�[0m
2023-08-01T13:00:13.7005276Z �[31m  ---�[0m�[0m
2023-08-01T13:00:13.7005643Z   �[0m
2023-08-01T13:00:13.7006507Z �[31m  [SQLSTATE: HY109](sql-error-conditions-sqlstates.html#class-HY-cli-specific-condition)�[0m�[0m
2023-08-01T13:00:13.7007808Z   �[0m
2023-08-01T13:00:13.7008893Z �[31m  The cursor is invalid.�[0m�[0m
2023-08-01T13:00:13.7009305Z   �[0m
2023-08-01T13:00:13.7009832Z �[31m  This error class has the following derived error classes:�[0m�[0m
2023-08-01T13:00:13.7018000Z   �[0m
2023-08-01T13:00:13.7018984Z �[31m  ## DISCONNECTED�[0m�[0m
2023-08-01T13:00:13.7019708Z   �[0m
2023-08-01T13:00:13.7030199Z �[31m  The cursor has been disconnected by the server.�[0m�[0m
2023-08-01T13:00:13.7030828Z   �[0m
2023-08-01T13:00:13.7037833Z �[31m  ## NOT_REATTACHABLE�[0m�[0m
2023-08-01T13:00:13.7045721Z   �[0m
2023-08-01T13:00:13.7052487Z �[31m  The cursor is not reattachable.�[0m�[0m
2023-08-01T13:00:13.7061683Z   �[0m
2023-08-01T13:00:13.7064730Z �[31m  ## POSITION_NOT_AVAILABLE�[0m�[0m
2023-08-01T13:00:13.7067834Z   �[0m
2023-08-01T13:00:13.7074207Z �[31m  The cursor position id `<responseId>` is no longer available at index `<index>`.�[0m�[0m
2023-08-01T13:00:13.7077949Z   �[0m
2023-08-01T13:00:13.7078856Z �[31m  ## POSITION_NOT_FOUND�[0m�[0m
2023-08-01T13:00:13.7082964Z   �[0m
2023-08-01T13:00:13.7084232Z �[31m  The cursor position id `<responseId>` is not found.]" did not equal "[]" The error class document is not up to date. Please regenerate it. (SparkThrowableSuite.scala:300)�[0m�[0m
2023-08-01T13:00:13.7088845Z �[31m  Analysis:�[0m�[0m
2023-08-01T13:00:13.7129719Z �[31m  "[---�[0m�[0m
2023-08-01T13:00:13.7130641Z �[31mlayout: global�[0m�[0m
2023-08-01T13:00:13.7149381Z �[31mtitle: INVALID_CURSOR error class�[0m�[0m
2023-08-01T13:00:13.7150359Z �[31mdisplayTitle: INVALID_CURSOR error class�[0m�[0m
2023-08-01T13:00:13.7151267Z �[31mlicense: |�[0m�[0m
2023-08-01T13:00:13.7151891Z �[31m  Licensed to the Apache Software Foundation (ASF) under one or more�[0m�[0m
2023-08-01T13:00:13.7152850Z �[31m  contributor license agreements.  See the NOTICE file distributed with�[0m�[0m
2023-08-01T13:00:13.7153566Z �[31m  this work for additional information regarding copyright ownership.�[0m�[0m
2023-08-01T13:00:13.7154225Z �[31m  The ASF licenses this file to You under the Apache License, Version 2.0�[0m�[0m
2023-08-01T13:00:13.7154916Z �[31m  (the "License"); you may not use this file except in compliance with�[0m�[0m
2023-08-01T13:00:13.7155523Z �[31m  the License.  You may obtain a copy of the License at�[0m�[0m
2023-08-01T13:00:13.7155948Z �[31m�[0m�[0m
2023-08-01T13:00:13.7156506Z �[31m     http://www.apache.org/licenses/LICENSE-2.0�[0m�[0m
2023-08-01T13:00:13.7156956Z �[31m�[0m�[0m
2023-08-01T13:00:13.7157502Z �[31m  Unless required by applicable law or agreed to in writing, software�[0m�[0m
2023-08-01T13:00:13.7158137Z �[31m  distributed under the License is distributed on an "AS IS" BASIS,�[0m�[0m
2023-08-01T13:00:13.7159032Z �[31m  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.�[0m�[0m
2023-08-01T13:00:13.7159701Z �[31m  See the License for the specific language governing permissions and�[0m�[0m
2023-08-01T13:00:13.7160264Z �[31m  limitations under the License.�[0m�[0m
2023-08-01T13:00:13.7160676Z �[31m---�[0m�[0m
2023-08-01T13:00:13.7161046Z �[31m�[0m�[0m
2023-08-01T13:00:13.7161708Z �[31m[SQLSTATE: HY109](sql-error-conditions-sqlstates.html#class-HY-cli-specific-condition)�[0m�[0m
2023-08-01T13:00:13.7162251Z �[31m�[0m�[0m
2023-08-01T13:00:13.7162677Z �[31mThe cursor is invalid.�[0m�[0m
2023-08-01T13:00:13.7163166Z �[31m�[0m�[0m
2023-08-01T13:00:13.7163669Z �[31mThis error class has the following derived error classes:�[0m�[0m
2023-08-01T13:00:13.7164121Z �[31m�[0m�[0m
2023-08-01T13:00:13.7164529Z �[31m## DISCONNECTED�[0m�[0m
2023-08-01T13:00:13.7164922Z �[31m�[0m�[0m
2023-08-01T13:00:13.7165482Z �[31mThe cursor has been disconnected by the server.�[0m�[0m
2023-08-01T13:00:13.7165938Z �[31m�[0m�[0m
2023-08-01T13:00:13.7166353Z �[31m## NOT_REATTACHABLE�[0m�[0m
2023-08-01T13:00:13.7166727Z �[31m�[0m�[0m
2023-08-01T13:00:13.7167173Z �[31mThe cursor is not reattachable.�[0m�[0m
2023-08-01T13:00:13.7167588Z �[31m�[0m�[0m
2023-08-01T13:00:13.7168031Z �[31m## POSITION_NOT_AVAILABLE�[0m�[0m
2023-08-01T13:00:13.7168821Z �[31m�[0m�[0m
2023-08-01T13:00:13.7169394Z �[31mThe cursor position id `<responseId>` is no longer available at index `<index>`.�[0m�[0m
2023-08-01T13:00:13.7169868Z �[31m�[0m�[0m
2023-08-01T13:00:13.7170273Z �[31m## POSITION_NOT_FOUND�[0m�[0m
2023-08-01T13:00:13.7170665Z �[31m�[0m�[0m
2023-08-01T13:00:13.7171183Z �[31mThe cursor position id `<responseId>` is not found.]" -> "[]"�[0m�[0m
2023-08-01T13:00:13.7196107Z �[31m  org.scalatest.exceptions.TestFailedException:�[0m�[0m

Strange that a part of Apache License seems to be pulled in into this diff?

@github-actions github-actions bot added the DOCS label Aug 1, 2023
@juliuszsompolski
Copy link
Contributor Author

Aaaaah.... so I regenerated the docs, but then forgot to git add the new file it generated.
It was passing locally for me, because the file was still there.

@juliuszsompolski juliuszsompolski changed the title [SPARK-44421][FOLLOWUP] Reenable test in SparkThrowableSuite [SPARK-44421][FOLLOWUP] Fix doc test in SparkThrowableSuite Aug 1, 2023
@HyukjinKwon
Copy link
Member

Merged to master and branch-3.5.

HyukjinKwon pushed a commit that referenced this pull request Aug 1, 2023
### What changes were proposed in this pull request?

Forgot to `git add` the file after regenerating docs.

### Why are the changes needed?

Fix docs and reenable test.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually testing SparkThrowableSuite works in both master and branch-3.5.

Closes #42263 from juliuszsompolski/SPARK-44421-SparkThrowableSuite-followup.

Authored-by: Juliusz Sompolski <julek@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 5b8eaf8)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@LuciferYang
Copy link
Contributor

late LGTM :)

ragnarok56 pushed a commit to ragnarok56/spark that referenced this pull request Mar 2, 2024
### What changes were proposed in this pull request?

Forgot to `git add` the file after regenerating docs.

### Why are the changes needed?

Fix docs and reenable test.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually testing SparkThrowableSuite works in both master and branch-3.5.

Closes apache#42263 from juliuszsompolski/SPARK-44421-SparkThrowableSuite-followup.

Authored-by: Juliusz Sompolski <julek@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants