Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-40497][BUILD] Re-upgrade Scala to 2.13.11 #42918

Closed
wants to merge 4 commits into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Sep 14, 2023

What changes were proposed in this pull request?

This PR aims to re-upgrade Scala to 2.13.11, after SPARK-45144 was merged, the build issues mentioned in #41943 should no longer exist.

Additionally, this pr adds a new suppression rule for warning message: Implicit definition should have explicit type, this is a new compile check introduced by scala/scala#10083, we must fix it when we upgrading to use Scala 3

Why are the changes needed?

This release improves collections, adds support for JDK 20 and 21, adds support for JDK 17 sealed:

There are 2 known issues in this version:

For the first one, there is no compilation warning messages related to match may not be exhaustive in Spark compile log, and for the second one, there is no case of method.isAnnotationPresent(Deprecated.class) in Spark code, there is just

val hasNonNull = readMethod.isAnnotationPresent(classOf[Nonnull])

in Spark Code, and I checked @javax.annotation.Nonnull no this issue.

So I think These two issues will not affect Spark itself, but this doesn't mean it won't affect the code written by end users themselves

The full release notes as follows:

Does this PR introduce any user-facing change?

Yes, this is a Scala version change.

How was this patch tested?

  • Existing Test

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the BUILD label Sep 14, 2023
@LuciferYang LuciferYang marked this pull request as draft September 14, 2023 02:42
@github-actions github-actions bot added the INFRA label Sep 14, 2023
@@ -207,6 +207,7 @@ jobs:
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
SKIP_PACKAGING: true
SCALA_PROFILE: scala2.13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert after test

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Sep 15, 2023

https://github.com/LuciferYang/spark/runs/16776579478
https://github.com/LuciferYang/spark/runs/16800035858

Tested Scala 2.13 + Java 17, onnly the org.apache.spark.sql.connect.execution.ReattachableExecuteSuite test failed, which is a known issue.

@github-actions github-actions bot removed the INFRA label Sep 15, 2023
@LuciferYang
Copy link
Contributor Author

cc @dongjoon-hyun FYI
also cc @eejbyfeldt for double check

@LuciferYang LuciferYang marked this pull request as ready for review September 15, 2023 05:53
Copy link
Contributor

@eejbyfeldt eejbyfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test building 2.13 with both Java 11 and Java 17 worked like expected. Thanks for fixing this!

2.13.12 has also been release https://github.com/scala/scala/releases/tag/v2.13.12 so we might want to look into that in the future.

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun and @eejbyfeldt

@LuciferYang
Copy link
Contributor Author

2.13.12 has also been release https://github.com/scala/scala/releases/tag/v2.13.12 so we might want to look into that in the future.

We can test it once Ammonite releases a new version supporting Scala 2.13.12.

@dongjoon-hyun
Copy link
Member

Could you re-trigger the failed pipelines?

@LuciferYang
Copy link
Contributor Author

Could you re-trigger the failed pipelines?

Triggered

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.0.0. Thank you, @LuciferYang and all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants