[SPARK-47599][MLLIB] MLLib: Migrate logWarn with variables to structured logging framework #46527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red logging framework
|
Let's continue on this one :) |
Okay, let me check it first, 😄 |
panbingkun
commented
May 14, 2024
| @@ -451,8 +451,8 @@ class KMeans @Since("1.5.0") ( | |||
|
|
|||
| private def trainWithBlock(dataset: Dataset[_], instr: Instrumentation) = { | |||
| if (dataset.storageLevel != StorageLevel.NONE) { | |||
| instr.logWarning(s"Input vectors will be blockified to blocks, and " + | |||
There was a problem hiding this comment.
Delete unnecessary string interpreter s"..."
panbingkun
commented
May 14, 2024
| @@ -179,8 +179,8 @@ class LinearSVC @Since("2.2.0") ( | |||
| maxBlockSizeInMB) | |||
|
|
|||
| if (dataset.storageLevel != StorageLevel.NONE) { | |||
| instr.logWarning(s"Input instances will be standardized, blockified to blocks, and " + | |||
There was a problem hiding this comment.
Delete unnecessary string interpreter. s"..."
panbingkun
commented
May 14, 2024
| @@ -129,9 +130,9 @@ class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val uid: String | |||
| if (Locale.getAvailableLocales.contains(Locale.getDefault)) { | |||
| Locale.getDefault | |||
| } else { | |||
| logWarning(s"Default locale set was [${Locale.getDefault.toString}]; however, it was " + | |||
There was a problem hiding this comment.
toString is redundant in our scenario. Let's remove it.
Ready for it! |
| s" If failure occurs try setting executor-memory ${memThreshold}m (or larger).") | ||
| logWarning(log"${MDC(LogKeys.CLASS_NAME, className)}.save() was called, " + | ||
| log"but it may fail because of too little executor memory " + | ||
| log"(${MDC(LogKeys.EXECUTION_MEMORY_SIZE, sc.executorMemory)}m). If failure occurs, " + |
There was a problem hiding this comment.
Suggested change
| log"(${MDC(LogKeys.EXECUTION_MEMORY_SIZE, sc.executorMemory)}m). If failure occurs, " + | |
| log"(${MDC(LogKeys.EXECUTOR_MEMORY_SIZE, sc.executorMemory)}m). If failure occurs, " + |
There was a problem hiding this comment.
Yeah, Good catch!
Thanks, updated!
gengliangwang
approved these changes
May 15, 2024
|
@panbingkun Thanks for the work. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to migrate
logWarnin moduleMLLibwith variables tostructured logging framework.Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.