Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48242][BUILD] Upgrade extra-enforcer-rules to 1.8.0 #46538

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented May 11, 2024

What changes were proposed in this pull request?

The pr aims to upgrade extra-enforcer-rules to 1.8.0 from 1.7.0 to 1.8.0.

Why are the changes needed?

The full release notes:
https://github.com/mojohaus/extra-enforcer-rules/releases/tag/1.8.0

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Manually test.
sh dev/test-dependencies.sh
  • Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label May 11, 2024
@panbingkun panbingkun marked this pull request as ready for review May 12, 2024 23:31
@panbingkun
Copy link
Contributor Author

cc @dongjoon-hyun

@LuciferYang
Copy link
Contributor

The change pipeline doesn't include Maven build tests now. Have you manually confirmed the validity of the upgrade?

@panbingkun
Copy link
Contributor Author

The change pipeline doesn't include Maven build tests now. Have you manually confirmed the validity of the upgrade?

Yeah, I have verified it in the last scala-2.13.14 upgrade. Let me verify it again. Wait a moment.

@panbingkun
Copy link
Contributor Author

checking process as follows:
1.When I delete the following and execute sh dev/test-dependencies.sh, the error is as follows:
image
image

2.When I restore (only update extra-enforcer-rules from 1.7.0 to 1.8.0) and execute sh dev/test-dependencies.sh, the results are as follows:
image

Meet expectations.

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@LuciferYang
Copy link
Contributor

Merged into master for Spark 4.0. Thanks @panbingkun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants