-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48246][BUILD] Add a new ScalaStyle Rule RedundantIfChecker
#46546
base: master
Are you sure you want to change the base?
Conversation
@panbingkun Does the Java side have similar rules? There are similar cases in the Java code, for example: Lines 52 to 62 in cae2248
|
There are similar rules on the |
@@ -64,4 +64,6 @@ | |||
files="src/main/java/org/apache/spark/sql/api/java/*"/> | |||
<suppress checks="IllegalImport" | |||
files="src/test/java/org/apache/spark/sql/hive/test/Complex.java"/> | |||
<suppress checks="SimplifyBooleanExpression" | |||
files="src/test/java/org/apache/spark/sql/hive/test/Complex.java" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changes were proposed in this pull request?
The pr aims to add a new
ScalaStyle
RuleRedundantIfChecker
.Why are the changes needed?
Make code logic more direct and intuitive.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.