[SPARK-48252][SQL] Update CommonExpressionRef when necessary #46552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @viirya |
viirya
reviewed
May 13, 2024
...lyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpressionSuite.scala
Outdated
Show resolved
Hide resolved
viirya
approved these changes
May 13, 2024
yaooqinn
reviewed
May 15, 2024
| if (newDef.dataType != oldDef.dataType || newDef.nullable != oldDef.nullable) { | ||
| val newRef = new CommonExpressionRef(newDef) | ||
| result.transform { | ||
| case oldRef: CommonExpressionRef if oldRef.id == newRef.id => |
There was a problem hiding this comment.
Nit: We can use oldRef.id == newDFef.id to avoid creating some newRef?
There was a problem hiding this comment.
unless there is dangling common expressions (it should not happen today), we should aways create a new ref when we know the def is different.
|
Hi, @cloud-fan . It seems that @viirya 's comment is marked |
|
oh, I accepted this code-change comment on Github but later on I pushed a new commit from local which discarded this change... |
…mizer/RewriteWithExpressionSuite.scala Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
|
The last commit just updates the test name, we don't need to re-test. I'm merging it to master, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
Withexpression assumes that it should be created after all input expressions are fully resolved. This is mostly true (function lookup happens after function input expressions are resolved), but there is a special case of column resolution in HAVING: we useTempResolvedColumnto try one column resolution option. If it doesn't work, re-resolve the column, which may be a different data type.Withexpression should update the refs when this happens.Why are the changes needed?
bug fix, otherwise the query will fail
Does this PR introduce any user-facing change?
This feature is not released yet.
How was this patch tested?
new test
Was this patch authored or co-authored using generative AI tooling?
no