Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignores ResizeObserver errors in development mode #24868

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

webpack-dev-server 4.12.0 added a new feature to show runtime errors in the error overlay by default which resulted in ResizeObserver errors when running Superset in development mode.

Screenshot 2023-08-02 at 09 56 17

We only have one use of ResizeObserver in our codebase and it's not the root cause for the error, so it must be coming from a third party dependency. Given that this type of error is benign, we even have discussions to downgrade it to a warning, this PR changes the Webpack configuration to ignore related error messages.

TESTING INSTRUCTIONS

Make sure the referenced error does not happen when running the application in development mode.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #24868 (d8489a1) into master (44e4fb1) will not change coverage.
The diff coverage is n/a.

❗ Current head d8489a1 differs from pull request most recent head b115e09. Consider uploading reports for the commit b115e09 to get more accurate results

@@           Coverage Diff           @@
##           master   #24868   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files        1904     1904           
  Lines       74107    74107           
  Branches     8194     8194           
=======================================
  Hits        51140    51140           
  Misses      20848    20848           
  Partials     2119     2119           
Flag Coverage Δ
javascript 55.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 434db0d into apache:master Aug 2, 2023
27 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants