Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate old Database endpoints #28404

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 9, 2024

SUMMARY

Deprecates all database views (server rendered) for databases

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 83.27%. Comparing base (76d897e) to head (b3fb911).
Report is 75 commits behind head on master.

Files Patch % Lines
superset/views/database/views.py 81.48% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28404       +/-   ##
===========================================
+ Coverage   60.48%   83.27%   +22.78%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37255    -38981     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31024    -15090     
+ Misses      28017     6231    -21786     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.10% <77.77%> (-0.07%) ⬇️
javascript ?
mysql 77.23% <81.48%> (?)
postgres 77.35% <81.48%> (?)
presto 53.69% <77.77%> (-0.12%) ⬇️
python 83.27% <81.48%> (+19.78%) ⬆️
sqlite 76.81% <81.48%> (?)
unit 58.37% <77.77%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch
Copy link
Member

@supersetbot orglabel

@mistercrunch
Copy link
Member

Not sure why supersetbot orglabel, but seems limited to @dpgaspar , unclear why, this should swallow the error for now
#28418

@dpgaspar dpgaspar merged commit 54e02f5 into apache:master May 13, 2024
35 of 37 checks passed
@dpgaspar dpgaspar deleted the danielgaspar/sc-80494/deprecate-old-databases-crud-system branch May 13, 2024 07:42
aehanno pushed a commit to kosmos-education/superset that referenced this pull request May 13, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants