Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix typo in development.mdx #28412

Merged
merged 1 commit into from
May 10, 2024
Merged

fix(docs): fix typo in development.mdx #28412

merged 1 commit into from
May 10, 2024

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented May 9, 2024 •
edited by michael-s-molina

SUMMARY

fix typo

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho marked this pull request as ready for review May 9, 2024 17:11
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label May 9, 2024
@eschutho eschutho added merge-if-green If approved and tests are green, please go ahead and merge it for me and removed doc Namespace | Anything related to documentation labels May 9, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label May 9, 2024
@mistercrunch mistercrunch changed the title fix:Update development.mdx fix: update development.mdx May 10, 2024
@sfirke sfirke merged commit 93e6542 into master May 10, 2024
36 of 59 checks passed
@sfirke sfirke deleted the eschutho-patch-1 branch May 10, 2024 14:03
@sfirke sfirke changed the title fix: update development.mdx fix(docs): fix typo in development.mdx May 10, 2024
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label May 10, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@eschutho @jzhao62
fix: update development.mdx (apache#28412)
a8d83f8
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@eschutho @EnxDev
fix: update development.mdx (apache#28412)
36e058d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
merge-if-green If approved and tests are green, please go ahead and merge it for me preset-io size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eschutho @mistercrunch @michael-s-molina @john-bodley @sfirke