[MINOR] maven-gpg-plugin update to version 3.0.1 #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- With version 1.6, it is not possible to sign artifacts with SHA-256 or higher using ```sh mvn -P'distribution' deploy -Daether.checksums.algorithms=SHA-256 ``` - The signing with SHA512 functionality has been added in 2016 by https://issues.apache.org/jira/browse/MPOM-118 - More about the plugin: https://maven.apache.org/plugins/maven-gpg-plugin/plugin-info.html
|
Please wait till I verify that my setup works with this change. As the release is nearing, I'd be conservative about any change. |
j143
changed the title
j143
changed the title
|
@phaniarnab - shall we take this in? |
ilovemesomeramen
pushed a commit
to ilovemesomeramen/systemds
that referenced
this pull request
Jul 21, 2021
gpg plugin does not sign the artifacts but simply provides .asc file. - More about the plugin: https://maven.apache.org/plugins/maven-gpg-plugin/plugin-info.html --- Commentary: Signing artifacts with SHA-256 or higher using maven resolver, which is part of maven core, but not with maven-gpg-plugin. If you are unable to sign the artifacts then upgrade to latest maven version. ```sh mvn -P'distribution' deploy -Daether.checksums.algorithms=SHA-256 ``` - The signing with SHA512 functionality has been added in 2016 by https://issues.apache.org/jira/browse/MPOM-118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happens with this plugin?
This plugin would only produce
.ascfiles only.https://maven.apache.org/plugins/maven-gpg-plugin/plugin-info.html
How maven signs artifacts with checksums?
The following is about Maven Resolver (part of
maven core)With version 1.6, it is not possible to sign artifacts with SHA-256 or higher
using
mvn -P'distribution' deploy -Daether.checksums.algorithms=SHA-256The signing with SHA512
https://issues.apache.org/jira/browse/MPOM-118
because, the SHA-512 functionality has been added recently
Issues related to gpg-signing elsewhere:
j143#99