THRIFT-5773: Strong UUID for C++ #2958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJCombrink
force-pushed
the
feature/THRIFT-5773_strong_uuid
branch
from
803bc86
to
45e11bb
Compare
CJCombrink
commented
Apr 23, 2024
| * This function will throw an exception if the string is not | ||
| * a valid UUID. | ||
| */ | ||
| TUuid& operator=(const std::string& str) noexcept(false); |
There was a problem hiding this comment.
Any comment on this function?
I am still very much in two minds if this function should ever exist.
Perhaps not since there is an explicit constructor taking a string.
I am concerned about the porting issue for people that already used a string like object (byte[16]) but wants to upgrade to using the strong UUID.
- The public data member is probably not convention, but this should be a light wrapper for added utility. - Stick with uint8_t[16] as discussed on ticket - Cleanup and unit tests added
- And fix begin() and end() - More unit test
- Test for network order
CJCombrink
force-pushed
the
feature/THRIFT-5773_strong_uuid
branch
from
45e11bb
to
5e16321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THRIFT-5773: UUID wrapper for C++
Adds a strong UUID wrapper for C++.
The use of a
std::stringcan be misleading and since C++ is a strong typed language, this makes the most sense.[skip ci]anywhere in the commit message to free up build resources.