-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto options for all experimental plugins #10967
Conversation
In case it's helpful:
Thanks for working on this. |
Blocking on #10968 for the OSX build. |
b71f171
to
4aadf97
Compare
[approve ci osx] |
The OSX failure is due to a CMake issue present in master. I discussed it with @cmcfarlen and am working on a fix. Marking this as a draft until then. |
[approve ci osx] |
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
7d1e308
to
311858f
Compare
This is about ready, but I still have to solve the problem of ImageMagick being used both in both the webp_transform and magick plugins. |
[approve ci] |
1621f99
to
1b35e96
Compare
It was discussed that it is clearer to have auto_options just set the |
6cfc433
to
95e4d44
Compare
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins. It was pointed out that WITH_SUBDIRECTORY is giving auto_options too many responsibilities and it will be removed.
95e4d44
to
0c19cd1
Compare
A CMake issue that caused the necessity for a workaround for ImageMagick is being tracked here: https://gitlab.kitware.com/cmake/cmake/-/issues/25970. |
Auto options were added for the experimental plugins with special dependencies in #10741. This adds options for the remaining experimental plugins.