Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage.yaml #11010

Closed
wants to merge 3 commits into from
Closed

Conversation

masaori335
Copy link
Contributor

@masaori335 masaori335 commented Jan 25, 2024

Address #10766. Implementation of merging storage.config and volume.config into storage.yaml. Docs will be changed by #11000.

TODOs

  • Test with raw disks
  • Decouple cleanups

@masaori335
Copy link
Contributor Author

  1. Rebased on the latest 11-Dev branch (4274bc0).
  2. Tested with raw devices on Linux. This generated the same result (total cache size and related debug messages) as before this change.

storage.config and volume.config without this PR

# storage.config
/dev/disk/by-path/AAAA volume=1
/dev/disk/by-path/BBBB volume=1
/dev/disk/by-path/CCCC volume=1
/dev/disk/by-path/DDDD volume=1
/dev/ram0 volume=2

# volume.config
volume=1 scheme=http size=100%
volume=2 scheme=http size=10485760000

storege.yaml with this PR

# storage.yaml
cache:
  spans:
    - id: "disk-1"
      path: /dev/disk/by-path/AAAA
    - id: "disk-2"
      path: /dev/disk/by-path/BBBB
    - id: "disk-3"
      path: /dev/disk/by-path/CCCC
    - id: "disk-4"
      path: /dev/disk/by-path/DDDD
    - id: "ram-1"
      path: /dev/ram0      
  volumes:
    - id: 1
      spans:
        - use: disk-1
        - use: disk-2
        - use: disk-3
        - use: disk-4
    - id: 2
      spans:
        - use: ram-1

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

@github-actions github-actions bot added the Stale label May 15, 2024
@github-actions github-actions bot closed this May 23, 2024
@masaori335 masaori335 reopened this May 23, 2024
@github-actions github-actions bot closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant