Add HTTP/2 Empty CONTINUATION & DATA frame counter #11345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
requested changes
May 13, 2024
Comment on lines
4582
to
4591
| .. ts:cv:: CONFIG proxy.config.http2.max_empty_frames_per_minute INT 0 | ||
| :reloadable: | ||
|
|
||
| Specifies how many empty frames |TS| receives for a minute at maximum. | ||
| What "empty frames" means here is DATA frame that does not carry payload | ||
| nor END_STREAM flag, and CONTINUATION frame that does not carry payload | ||
| nor END_HEADERS flag. | ||
| Clients exceeded this limit will be immediately disconnected with an error | ||
| code of ENHANCE_YOUR_CALM. | ||
|
|
There was a problem hiding this comment.
It would be good to document that a negative value means unlimited for these relevant configurations. A default statement would also be helpful. Maybe something like:
Any negative value configures no limit to the number of empty frames received. ``0`` is
the default configuration, meaning that no empty frames are allowed.
|
[approve ci autest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.