Add tests for writing documents to the cache #11347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahWI
force-pushed
the
refactor/test-aggWrite
branch
2 times, most recently
from
c173fd4
to
79d295c
Compare
This tests that the correct document data is written to cache by aggWrite. It also covers some fields of the Doc struct used for reading the data: the magic value, the length and header length, and the optional checksum. This commit also fixes the use of an uninitialized variable (header.phase) reported by valgrind by initializing it to the same default value used in the Stripe::_clear_init.
This tests VCs with f.evacuator set to make sure all main code paths in agg_copy are covered. It is very similar to the test for normal VCs, but sets the buffer up with a document instead of the raw content string. This commit also moves FakeVC and WaitingVC into a new file called test_doubles.h.
JosiahWI
force-pushed
the
refactor/test-aggWrite
branch
from
79d295c
to
5df0c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that the correct document data is written to cache by aggWrite. It also covers some fields of the Doc struct used for reading the data: the magic value, the length and header length, and the optional checksum.
This commit also fixes the use of an uninitialized variable (header.phase) reported by valgrind by initializing it to the same default value used in the Stripe::_clear_init.