Add http2.incomplete_header_timeout_in #11354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but can we add or alter an Au test to exercise the new code? |
|
Adding AuTest looks good idea, but let me do that in another PR later. Because we need to have a special client or extend proxy-verifier. ( I have a client to test this code but it's written in go-lang ) |
ywkaras
approved these changes
May 23, 2024
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
May 24, 2024
(cherry picked from commit b46f5d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new active timeout for incoming HTTP/2 stream. This requires clients to complete sending HTTP headers (send END_HEADERS flag on HEADERS or CONTINUATION frame) within the configured timeout.
Default value is
10sas we talked at ATS Summit in Denver.Timing of setting and canceling timeouts will be below.