Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined behavior doing memcpy from timespec** #11356

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix undefined behavior doing memcpy from timespec** #11356

merged 1 commit into from
May 15, 2024

Conversation

freak82
Copy link
Contributor

@freak82 freak82 commented May 15, 2024

The code was wrongly copying from timespec** to timespec*.
There was a warning emitted from GCC 13.2 about this.

@freak82
Fix undefined behavior doing memcpy from timespec** instead from time…
486b7e5 
…spec*

The code was wrongly copying from timespec** to timespec*.
There was a warning emitted from GCC 13.2 about this.
@brbzull0 brbzull0 added the Bug label May 15, 2024
@brbzull0 brbzull0 added this to the 10.1.0 milestone May 15, 2024
@brbzull0 brbzull0 self-requested a review May 15, 2024 09:07
@brbzull0
Copy link
Contributor

Good find, thanks again @freak82.
#11355 (comment)

@JosiahWI
Copy link
Collaborator

Also fixes CID 1545133 from Coverity.

@ezelkow1
Copy link
Member

[approve ci]

@brbzull0
Copy link
Contributor

[approve ci autest]

brbzull0
brbzull0 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@brbzull0 brbzull0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@brbzull0 brbzull0 merged commit 4dc6bed into apache:master May 15, 2024
15 checks passed
@cmcfarlen cmcfarlen modified the milestones: 10.1.0, 10.0.0 May 16, 2024
@cmcfarlen
Copy link
Contributor

Cherry-picked to v10.0.x

cmcfarlen pushed a commit that referenced this pull request May 16, 2024
@freak82 @cmcfarlen
Fix undefined behavior doing memcpy from timespec** instead from time…
9a54d66 
…spec* (#11356)

The code was wrongly copying from timespec** to timespec*.
There was a warning emitted from GCC 13.2 about this.

(cherry picked from commit 4dc6bed)
@freak82 freak82 deleted the fix-memcpy-UB branch May 17, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbzull0 brbzull0 brbzull0 approved these changes

Assignees

@freak82 freak82

Labels
Bug Coverity
Projects
ATS v10.0.x
Status: picked-10.0.0
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@freak82 @brbzull0 @JosiahWI @ezelkow1 @cmcfarlen