[UnitTest] Use pytest's scope='session' for tvm.testing.parameter #16930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
tvm_testing_fixture_at_session_scope
branch
from
6fa33b6
to
5ef2c8b
Compare
Prior to this commit, the `tvm.testing.parameter` utility defined a fixture with the default `scope="function"`. However, this prevents use of these parameters as arguments for other fixtures that are themselves cached using pytest. Since these are parameters, not large values that would be expensive to compute, there is no downside to caching them at the pytest level. This commit updates the scope of fixtures generated using `tvm.testing.parameter` to use `scope="session"` instead of the default `scope="function"`.
Lunderberg
force-pushed
the
tvm_testing_fixture_at_session_scope
branch
from
5ef2c8b
to
46a0483
Compare
masahi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
tvm.testing.parameterutility defined a fixture with the defaultscope="function". However, this prevents use of these parameters as arguments for other fixtures that are themselves cached using pytest. Since these are parameters, not large values that would be expensive to compute, there is no downside to caching them at the pytest level.This commit updates the scope of fixtures generated using
tvm.testing.parameterto usescope="session"instead of the defaultscope="function".