[YUNIKORN-815] Fix scheduler interface makefile issues #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downgrade gRPC version, because the shim repo depends on K8s 1.16, the etcd is not compatible with gRPC 1.32, see: etcd-io/etcd#12124. As a result, we are stick to gRPC 1.26.0 for now, unless the etcd updated to a version that is compatible with the newer gRPC versions. Accordingly, we need to use the plugin "--go_out=plugins=grpc" option to generate the gRPC code, otherwise it will generate some annotations that is not compatible with gRPC 1.26.0.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Downgrade gRPC version, because the shim repo depends on K8s 1.16, the etcd is not
compatible with gRPC 1.32, see: etcd-io/etcd#12124. As a
result, we are stick to gRPC 1.26.0 for now, unless the etcd updated to a version
that is compatible with the newer gRPC versions. Accordingly, we need to use the plugin
"--go_out=plugins=grpc" option to generate the gRPC code, otherwise it will generate
some annotations that is not compatible with gRPC 1.26.0.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-815
How should this be tested?
Screenshots (if appropriate)
Questions: