Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips #4523

Merged
merged 3 commits into from Dec 29, 2022

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Nov 30, 2022

What is this PR for?

I suppose this upgrade will not introduce compatibility issue, see details discussion about version requirements and compatibility apache/incubator-uniffle#13

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

ZEPPELIN-5857

How should this be tested?

Build on my M1 mac.

Screenshots (if appropriate)

before
image

after
image

Questions:

  • Does the licenses files need to update? Yes, and updated.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

@pan3793 pan3793 marked this pull request as draft December 1, 2022 06:42
@jongyoul
Copy link
Member

jongyoul commented Dec 1, 2022

I've checked the link you added but it's a bit different because we are using another maven plugin so I cannot reproduce the error like you. Could you please check it? BTW, I like the approach you suggested but we'd better change more to make them the same. Could you please check and modify them?

@pan3793
Copy link
Member Author

pan3793 commented Dec 4, 2022

@jongyoul are you using x86 JDK w/ Rosetta? the native aarch64 JDK should fail.

➜  apache-zeppelin git:(ZEPPELIN-5857) java -version
openjdk version "1.8.0_332"
OpenJDK Runtime Environment (Zulu 8.62.0.19-CA-macos-aarch64) (build 1.8.0_332-b09)
OpenJDK 64-Bit Server VM (Zulu 8.62.0.19-CA-macos-aarch64) (build 25.332-b09, mixed mode)

@pan3793
Copy link
Member Author

pan3793 commented Dec 4, 2022

typically, the native aarch64 JDK is 2x faster than x86 JDK w/ Rosetta (tested by compiling Apache Spark and Apache Kyuubi)

@jongyoul
Copy link
Member

jongyoul commented Dec 9, 2022

I tested it failed with aarch64 jdk. Thank you for letting me know.

@pan3793 pan3793 marked this pull request as ready for review December 9, 2022 15:02
@pan3793
Copy link
Member Author

pan3793 commented Dec 29, 2022

@jongyoul this is ready for review, I believe the CI failure is irrelevant.

I can success build the project(except to frontend modules) using Java8 aarch64 on M1 mac now.

@jongyoul jongyoul merged commit 09bd938 into apache:master Dec 29, 2022
khwj pushed a commit to khwj/zeppelin that referenced this pull request Jan 21, 2023
…hips (apache#4523)

* [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

* fix

* nit
khwj pushed a commit to khwj/zeppelin that referenced this pull request Jan 21, 2023
…hips (apache#4523)

* [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

* fix

* nit
proceane pushed a commit to proceane/zeppelin that referenced this pull request Feb 16, 2023
…hips (apache#4523)

* [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

* fix

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants