New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips #4523
Conversation
I've checked the link you added but it's a bit different because we are using another maven plugin so I cannot reproduce the error like you. Could you please check it? BTW, I like the approach you suggested but we'd better change more to make them the same. Could you please check and modify them? |
@jongyoul are you using x86 JDK w/ Rosetta? the native aarch64 JDK should fail.
|
typically, the native aarch64 JDK is 2x faster than x86 JDK w/ Rosetta (tested by compiling Apache Spark and Apache Kyuubi) |
I tested it failed with aarch64 jdk. Thank you for letting me know. |
779a553
to
d91f5c5
Compare
d91f5c5
to
a767d28
Compare
@jongyoul this is ready for review, I believe the CI failure is irrelevant. I can success build the project(except to frontend modules) using Java8 aarch64 on M1 mac now. |
…hips (apache#4523) * [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips * fix * nit
…hips (apache#4523) * [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips * fix * nit
…hips (apache#4523) * [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips * fix * nit
What is this PR for?
I suppose this upgrade will not introduce compatibility issue, see details discussion about version requirements and compatibility apache/incubator-uniffle#13
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-5857
How should this be tested?
Build on my M1 mac.
Screenshots (if appropriate)
before
after
Questions: