Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 in default #4652

Merged
merged 11 commits into from Oct 6, 2023

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Sep 11, 2023

What is this PR for?

Followup ZEPPELIN-5946, Use Spark 3.4.1 in default

What type of PR is it?

Improvement
Documentation

Todos

  • - Task

What is the Jira issue?

ZEPPELIN-5946

How should this be tested?

Pass GA

Screenshots (if appropriate)

Questions:

  • Does the license files need to update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@Reamer
Copy link
Contributor

Reamer commented Sep 11, 2023

Thx for the follow-up.

@pan3793
Copy link
Member Author

pan3793 commented Sep 12, 2023

The failed Kotlin test seems to be https://youtrack.jetbrains.com/issue/KT-38325

I suppose we must upgrade Kotlin first to address it. Unfortunately, the Kotlin interpreter uses a very old version (1.3.x, the latest is 1.9.x), and couple with lots of unstable APIs.

https://endoflife.date/kotlin

@Reamer
Copy link
Contributor

Reamer commented Sep 19, 2023

@pan3793
Is this PR ready for review?

@pan3793
Copy link
Member Author

pan3793 commented Sep 19, 2023

@Reamer not yet, I need to revert some changes.

Sorry, I'm quite busy these days, will find the time to finish it ASAP.

@pan3793 pan3793 changed the title [ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 and Scala 2.12 in default [ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 in default Sep 28, 2023
@pan3793
Copy link
Member Author

pan3793 commented Sep 28, 2023

The profiles scala-2.11 and scala-2.12 defined at root pom.xml seems only affects the livy module's test, if so, do we really need to maintain such profiles? Why not hardcode in livy/pom.xml(seems livy is not much active, the latest version only support Scala 2.11)

@pan3793 pan3793 marked this pull request as ready for review September 28, 2023 10:23
@pan3793
Copy link
Member Author

pan3793 commented Sep 28, 2023

cc @Reamer

@Reamer
Copy link
Contributor

Reamer commented Sep 28, 2023

The profiles scala-2.11 and scala-2.12 defined at root pom.xml seems only affects the livy module's test, if so, do we really need to maintain such profiles? Why not hardcode in livy/pom.xml(seems livy is not much active, the latest version only support Scala 2.11)

The profiles scala-2.11 and scala-2.12 set the properties scala.version and scala.binary.version.

I see accesses to these properties in the Zeppelin Display Module and Zeppelin Distribution Module. Unfortunately, I don't currently know why Scala dependencies are needed in the Zeppelin Distribution Module.

<dependencies>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
<version>${scala.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-compiler</artifactId>
<version>${scala.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scalap</artifactId>
<version>${scala.version}</version>
<scope>provided</scope>
</dependency>
</dependencies>

<dependencies>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
<version>${scala.version}</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-compiler</artifactId>
<version>${scala.version}</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-reflect</artifactId>
<version>${scala.version}</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scalap</artifactId>
<version>${scala.version}</version>
</dependency>
</dependencies>

@pan3793
Copy link
Member Author

pan3793 commented Sep 28, 2023

Oh, I missed the Zeppelin Display Module(it does not appear when I do global search using IDEA), it leverages the scala-xml to build AngularElem, that's why scala is required

@pan3793
Copy link
Member Author

pan3793 commented Sep 28, 2023

Emm, is "Zeppelin Display Module" only used by "Zeppelin: Spark Interpreter"? If so, I suppose the Zeppelin core becomes scala free if we can merge this module into "Zeppelin: Spark Interpreter"

@Reamer
Copy link
Contributor

Reamer commented Sep 28, 2023

As far as I know, the Zeppelin display module is only used by the Spark interpreter.

If it is possible we can merge the Display Module to the Spark Interpreter Module.

@pan3793
Copy link
Member Author

pan3793 commented Sep 28, 2023

As far as I know, the Zeppelin display module is only used by the Spark interpreter.

If it is possible we can merge the Display Module to the Spark Interpreter Module.

Thanks for information, would like a try in another PR.

I limit this PR's scope to the spark related stuffs, CI already passed, and the last commit only touch the docs

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reamer
Copy link
Contributor

Reamer commented Oct 4, 2023

I will merge this pull request on Friday as long as no other comment is received.

Copy link
Member

@jongyoul jongyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this PR. LGTM

@Reamer Reamer merged commit 3ebb815 into apache:master Oct 6, 2023
32 checks passed
@pan3793 pan3793 deleted the ZEPPELIN-5946-followup branch October 9, 2023 02:13
akoira pushed a commit to akoira/zeppelin that referenced this pull request Feb 1, 2024
* [ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 and Scala 2.12 in default

* Update docs/setup/basics/how_to_build.md

Co-authored-by: Matthias Koch <23187557+matthias-koch@users.noreply.github.com>

* reflect

* default 2.11

---------

Co-authored-by: Matthias Koch <23187557+matthias-koch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants