Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6017] Revert changes about ZEPPELIN_IDENT_STRING in ZEPPELIN-5421 #4760

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

kevinjmh
Copy link
Member

@kevinjmh kevinjmh commented Apr 25, 2024

What is this PR for?

#4146 delete the definition check about ZEPPELIN_IDENT_STRING in case of surefire version upgrade
but it will make the log file names become: 

zeppelin--SERVER.log
zeppelin--SERVER.out
zeppelin-interpreter-jdbc-shared_process–SERVER.log

in the defintion of:

zeppelin-${ZEPPELIN_IDENT_STRING}-${HOSTNAME}.log
zeppelin-${ZEPPELIN_IDENT_STRING}-${HOSTNAME}.out
zeppelin-interpreter-%INTERPRETER_ID%%ZEPPELIN_IDENT_STRING%%HOSTNAME%.log

so, we revert changes about ZEPPELIN_IDENT_STRING to fix the filename

What type of PR is it?

Hot Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6017

@jongyoul
Copy link
Member

@Reamer hello, could you please check this PR?

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kevinjmh
The changes look good to me. Can you please create a JIRA ticket and adjust the pull request description.

@kevinjmh kevinjmh changed the title [WIP] Check 5421 $ZEPPELIN_IDENT_STRING [ZEPPELIN-6017] Revert changes about ZEPPELIN_IDENT_STRING in ZEPPELIN-5421 Apr 26, 2024
@kevinjmh
Copy link
Member Author

Hi @kevinjmh The changes look good to me. Can you please create a JIRA ticket and adjust the pull request description.

@Reamer Please check

@Reamer Reamer merged commit d16ef69 into apache:master Apr 27, 2024
27 of 28 checks passed
@kevinjmh kevinjmh deleted the c5421 branch April 28, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants