Update package.json. Bump chart.js version to 2.7.3 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update package.json. Bump chart.js version to 2.7.3. We're using vue-chartjs in a web component. Shadow DOM support was added in Version 2.7.3 chartjs/Chart.js#5585 .
|
Well, ... I don't really get this PR. 🤔
Thats the reason why you need to install both. So as you have to install chart.js by yourself you are free to use any version you want. You changed only the devDependency, which has no effect for the published build. |
|
True. I was mistaken. It doesn't hurt to bump the dev version though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package.json. Bump chart.js version to 2.7.3.
We're using vue-chartjs in a web component. Shadow DOM support was added in Version 2.7.3 chartjs/Chart.js#5585 .
Fix or Enhancement?
Environment