Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typescript issue #614 #621

Merged
merged 6 commits into from Jun 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
Expand Up @@ -63,6 +63,9 @@
"peerDependencies": {
"chart.js": ">= 2.5"
},
"dependencies": {
"@types/chart.js": "^2.7.55"
},
"devDependencies": {
"@babel/cli": "^7.0.0-beta.42",
"@babel/core": "^7.0.0-beta.42",
Expand Down
4 changes: 2 additions & 2 deletions types/components.d.ts
@@ -1,8 +1,8 @@
import Vue from 'vue'
import { ChartData, ChartOptions } from 'chart.js';
import 'chart.js'

/** vue-chartjs component common definition */
export declare class BaseChart extends Vue {
addPlugin (plugin?: object): void
renderChart (chartData: ChartData, options?: ChartOptions): void
renderChart (chartData: Chart.ChartData, options?: Chart.ChartOptions): void
}
6 changes: 3 additions & 3 deletions types/mixins.d.ts
@@ -1,10 +1,10 @@
import Vue from 'vue';
import { ChartData } from 'chart.js';
import 'chart.js';

export declare class ReactiveDataMixin extends Vue {
chartData: ChartData;
chartData: Chart.ChartData;
}

export declare class ReactivePropMixin extends Vue {
readonly chartData: ChartData;
readonly chartData: Chart.ChartData;
}