New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chart.js 3.0 support #754
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
747085a
chore: update chartjs to 3rd version
thabarbados 848393d
chore: change generate chart actions
thabarbados f76ce6f
chore: change custom chart example
thabarbados f4b7a7f
chore: fix tests
thabarbados 0fd1716
chore: change generate chart action for chartjs3 changes
thabarbados 5c402f5
refactor: change sandboxes examples
thabarbados fe3bb9a
refactor: change test examples
thabarbados 93080f9
chore: add size-limit
thabarbados 288da8d
refactor: removed horizontal bar chart
thabarbados f51c995
refactor: add check size github action
thabarbados ceec67b
fix: check size limit actionn branch
thabarbados File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Checks | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| jobs: | ||
| size: | ||
| runs-on: ubuntu-latest | ||
| name: Checking size | ||
| if: "!contains(github.event.head_commit.message, '[ci skip]')" | ||
| env: | ||
| CI_JOB_NUMBER: 1 | ||
| steps: | ||
| - name: Checkout the repository | ||
| uses: actions/checkout@v2 | ||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v2.0.1 | ||
| with: | ||
| version: 6 | ||
| - name: Install Node.js | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
| cache: 'pnpm' | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
| - name: Check size | ||
| uses: andresz1/size-limit-action@v1 | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| skip_step: install | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| [ | ||
dangreen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| "path": "dist/index.cjs", | ||
| "limit": "2.2 KB", | ||
| "webpack": false, | ||
| "running": false | ||
| }, | ||
| { | ||
| "path": "dist/index.cjs", | ||
| "limit": "700 B", | ||
| "import": "{ Chart }" | ||
| }, | ||
| { | ||
| "path": "dist/index.js", | ||
| "limit": "2 KB", | ||
| "webpack": false, | ||
| "running": false | ||
| }, | ||
| { | ||
| "path": "dist/index.js", | ||
| "limit": "300 B", | ||
| "import": "{ Chart }" | ||
| } | ||
| ] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code from master has pnpm support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thabarbados look at the suggestion carefully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dangreen sorry, fixed