fix(legacy-charts): multi-chart data change bug #814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thabarbados
requested changes
Apr 20, 2022
There was a problem hiding this comment.
Thanks for this PR. Yes, it fixes a bug when rendering multiple reactive charts on the same page. But, it returns a bug when using the chartjs-plugin-annotation. We need to find a solution that would fix both bugs.
| @@ -23,7 +23,7 @@ import { | |||
| } from '../../src/utils' | |||
|
|
|||
| export function generateChart(chartId, chartType, chartController) { | |||
| let _chartRef = null | |||
| // let _chartRef = null | |||
There was a problem hiding this comment.
please remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or Enhancement?
Fixed #801
Environment