Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent stuck tooltip for line & candlestick charts #3664

Merged

Conversation

ettoredn
Copy link
Contributor

@ettoredn ettoredn commented Feb 23, 2023

Prevent tooltip stuck for line & candlestick charts

Prevent tooltip being stuck for mixed line & candlestick charts when first series type is candlestick and all other (line) series are hidden.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ettoredn ettoredn force-pushed the mixed-candlestick-tooltip-stuck branch from f90ac59 to 185dc1b Compare February 23, 2023 17:22
@junedchhipa
Copy link
Contributor

Hey @ettoredn
Thanks for the contribution. Can you just remove all files under dist/ from this PR? It only needs to be updated on next releases.

@ettoredn ettoredn force-pushed the mixed-candlestick-tooltip-stuck branch from 247f7c1 to 86ad6f2 Compare February 28, 2023 20:15
@ettoredn
Copy link
Contributor Author

Hey @junedchhipa , I just did.

…st series is candlestick and all other series are hidden

fix: properly select first visible series when creating shared tooltip
@ettoredn ettoredn force-pushed the mixed-candlestick-tooltip-stuck branch from 86ad6f2 to b1d4367 Compare February 28, 2023 20:51
@ettoredn ettoredn changed the title Prevent tooltip stuck for line & candlestick charts Prevent stuck tooltip for line & candlestick charts Mar 1, 2023
@junedchhipa junedchhipa merged commit 42d5e19 into apexcharts:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants