Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't render markers outside graph area #3679

Merged
merged 1 commit into from Mar 3, 2023
Merged

fix: don't render markers outside graph area #3679

merged 1 commit into from Mar 3, 2023

Conversation

leinonen
Copy link
Contributor

@leinonen leinonen commented Mar 2, 2023

New Pull Request

Markers renders outside graph area, which is not so nice.
image

Codepen that demonstrate the bug: https://codepen.io/leinonen/pen/xxaqmrX

Fixes #3320, #3562

Avoid rendering markers that are outside the graph area.
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@junedchhipa junedchhipa merged commit ea8ecaa into apexcharts:main Mar 3, 2023
junedchhipa added a commit that referenced this pull request Mar 26, 2023
@rdar-lab
Copy link

rdar-lab commented Apr 8, 2023

Please note before attempting to merge this again. It also removed points that were exactly on the edge which we were using for specific logic. This caused a very critical bug with our system. @leinonen, I suggest having a configuration parameter for this if you would like to re-introduce this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markers overflow on yaxis when zoom in with area/line chart
3 participants