Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for numeric series names #3770

Merged
merged 3 commits into from Jun 7, 2023
Merged

Fix for numeric series names #3770

merged 3 commits into from Jun 7, 2023

Conversation

MHewison
Copy link
Contributor

@MHewison MHewison commented Apr 19, 2023

New Pull Request

Exporting charts which have used integers as series name causes an error. This PR is to simple coerce the passed series title into a string for export purposes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@junedchhipa
Copy link
Contributor

Please remove the /dist directory as it is only required when a new version is built.

@junedchhipa junedchhipa merged commit bb1832f into apexcharts:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants