Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: set Null values to 0 when cnf.chart.stacked #3813

Merged
merged 1 commit into from May 20, 2023

Conversation

normannMarit
Copy link
Contributor

@normannMarit normannMarit commented May 7, 2023

New Pull Request

I removed the condition for the chart.type to be exclusively 'bar', otherwise when we mix types, we get undefined instead of 0 on stacked bars

Before:
issue
After:
resolution

Fixes #3811

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…me series when cnf.chart.stacked

I removed the condition for the chart.type to be exclusively 'bar', otherwise when we mix types, we get undefined instead of 0 on stacked bars
@junedchhipa junedchhipa merged commit c8344af into apexcharts:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding second legend item does not stack rest of bars
3 participants