Create React App v2 #849
Merged
Create React App v2 #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Oct 1, 2018
admin/package.json
Outdated
| @@ -9,12 +9,12 @@ | |||
| "react-dom": "^16.3.0" | |||
| }, | |||
| "devDependencies": { | |||
| "react-scripts": "^1.1.0" | |||
| "react-scripts": "2.0.1" | |||
There was a problem hiding this comment.
I would keep the ^ syntax for both package.json files. It will make the maintenance easier on our side.
dunglas
approved these changes
Oct 1, 2018
Fabious
commented
Oct 2, 2018
| }, | ||
| "scripts": { | ||
| "start": "react-scripts start", | ||
| "build": "react-scripts build", | ||
| "test": "react-scripts test", | ||
| "eject": "react-scripts eject" | ||
| } | ||
| }, | ||
| "browserslist": [ |
There was a problem hiding this comment.
Do we keep this ? it's added since create-react-app v2
dunglas
approved these changes
Oct 2, 2018
|
Thanks @Fabious! Great job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-react-app is very soon to be updated to version 2, and adds really cool features, as you can see here : facebook/create-react-app#5103
This PR is meant for api-platform to be ready for it
I used
$ yarn add --exact react-scripts@2.0.1