fix(metadata): fix Operations sort

api-platform · Mar 7, 2024 · 1c2509f · 1c2509f
1 parent 055fb38
commit 1c2509f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/src/Metadata/ApiResource.php b/src/Metadata/ApiResource.php
@@ -1018,6 +1018,7 @@ public function withOperations(Operations $operations): self
     {
         $self = clone $this;
         $self->operations = $operations;
+        $self->operations->sort();
 
         return $self;
     }

diff --git a/src/Metadata/Resource/Factory/AttributesResourceMetadataCollectionFactory.php b/src/Metadata/Resource/Factory/AttributesResourceMetadataCollectionFactory.php
@@ -121,7 +121,7 @@ private function buildResourceOperations(array $attributes, string $resourceClas
             [$key, $operation] = $this->getOperationWithDefaults($resources[$index], $operationAttribute);
             $operation = $operation->withPriority(++$operationPriority);
             $operations = $resources[$index]->getOperations() ?? new Operations();
-            $resources[$index] = $resources[$index]->withOperations($operations->add($key, $operation)->sort());
+            $resources[$index] = $resources[$index]->withOperations($operations->add($key, $operation));
         }
 
         // Loop again and set default operations if none where found

diff --git a/src/Metadata/Resource/Factory/MainControllerResourceMetadataCollectionFactory.php b/src/Metadata/Resource/Factory/MainControllerResourceMetadataCollectionFactory.php
@@ -52,7 +52,7 @@ public function create(string $resourceClass): ResourceMetadataCollection
                 }
             }
 
-            $resource = $resource->withOperations($operations->sort());
+            $resource = $resource->withOperations($operations);
             $resourceMetadataCollection[$i] = $resource;
         }
 

diff --git a/src/Metadata/Resource/Factory/OperationNameResourceMetadataCollectionFactory.php b/src/Metadata/Resource/Factory/OperationNameResourceMetadataCollectionFactory.php
@@ -56,7 +56,7 @@ public function create(string $resourceClass): ResourceMetadataCollection
                 $operations->remove($operationName)->add($newOperationName, $operation->withName($newOperationName));
             }
 
-            $resourceMetadataCollection[$i] = $resource->withOperations($operations->sort());
+            $resourceMetadataCollection[$i] = $resource->withOperations($operations);
         }
 
         return $resourceMetadataCollection;

diff --git a/src/Metadata/Resource/Factory/UriTemplateResourceMetadataCollectionFactory.php b/src/Metadata/Resource/Factory/UriTemplateResourceMetadataCollectionFactory.php
@@ -88,7 +88,7 @@ public function create(string $resourceClass): ResourceMetadataCollection
                 $operations->add($operation->getName(), $operation);
             }
 
-            $resource = $resource->withOperations($operations->sort());
+            $resource = $resource->withOperations($operations);
             $resourceMetadataCollection[$i] = $resource;
         }