Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data persister remove stops after 1st match #2223

Merged
merged 1 commit into from Oct 2, 2018
Merged

Fix data persister remove stops after 1st match #2223

merged 1 commit into from Oct 2, 2018

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Oct 1, 2018

Constistency with persist, see api-platform/docs#540 (comment)

dunglas
dunglas approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test to prevent future regressions?

@soyuka soyuka merged commit ea4a64c into api-platform:2.3 Oct 2, 2018
@soyuka soyuka deleted the remove-persister branch October 2, 2018 12:39
@antograssiot antograssiot mentioned this pull request Oct 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soyuka @dunglas