Import AnnotationsProvider & Parser from NelmioApiDocBundle #410
Conversation
teohhanhui
force-pushed
the
nelmio_import
branch
2 times, most recently
from
21acc3d
to
52b3369
Compare
|
Nice! The problem is that there are conflicts now, could you fix them? |
teohhanhui
force-pushed
the
nelmio_import
branch
from
52b3369
to
f6fd716
Compare
|
Rebased to latest master. Lots of refactoring. I hope it's correct. Help needed for adapting tests from NelmioApiDocBundle. |
teohhanhui
force-pushed
the
nelmio_import
branch
from
f6fd716
to
4fb4fdb
Compare
| * | ||
| * @author Kévin Dunglas <dunglas@gmail.com> | ||
| */ | ||
| class ApiPlatformProvider implements AnnotationsProviderInterface |
|
I left some minor comments but you made - again - an awesome work. What kind of help do you needs for importing test? IMO we can adapt:
And use one of the test entity from the |
teohhanhui
force-pushed
the
nelmio_import
branch
from
4fb4fdb
to
e052628
Compare
teohhanhui
changed the title
teohhanhui
force-pushed
the
nelmio_import
branch
from
e052628
to
93ae607
Compare
teohhanhui
force-pushed
the
nelmio_import
branch
from
93ae607
to
e778e58
Compare
| $prefixedShortName = ($iri = $resourceMetadata->getIri()) ? $iri : '#'.$resourceMetadata->getShortName(); | ||
| $resourceHydraDoc = $this->getResourceHydraDoc($hydraDoc, $prefixedShortName); | ||
|
|
||
| if ($hydraDoc) { |
There was a problem hiding this comment.
@dunglas I'm very curious about this condition. It looks wrong to me... This check would have been done before the loop if this was your intention...
I basically did not change any logic from the previous code (only adapting them to changes). This is the same from https://github.com/nelmio/NelmioApiDocBundle/blob/2a0f95eac0ab2aa466545d0b21d15739636811b7/Extractor/AnnotationsProvider/DunglasApiProvider.php#L71
|
@api-platform/core-team |
Import AnnotationsProvider & Parser from NelmioApiDocBundle
|
Thanks @teohhanhui |
Continuation of #225
Includes fix for nelmio/NelmioApiDocBundle#678