Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonschema) don't skip remaining multiple union types #6223

Merged
merged 1 commit into from Mar 19, 2024

Conversation

GwendolenLynch
Copy link
Contributor

Q A
Branch? 3.2
Tickets Closes #6212
License MIT

As requested by @soyuka

For the tests I just imported what I had in a sandbox to create the issue. Happy to modify on request.

@GwendolenLynch GwendolenLynch force-pushed the fix/issues/6212 branch 3 times, most recently from 9c8b786 to a4b7971 Compare March 16, 2024 09:22
Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Minor fixes. Need to fix the CI, then LGTM

@GwendolenLynch

This comment was marked as resolved.

@vincentchalamon

This comment was marked as resolved.

@GwendolenLynch GwendolenLynch force-pushed the fix/issues/6212 branch 2 times, most recently from 59a21da to d4b25ec Compare March 19, 2024 15:02
@GwendolenLynch GwendolenLynch force-pushed the fix/issues/6212 branch 2 times, most recently from 71b36a5 to 8031dae Compare March 19, 2024 15:47
@soyuka soyuka merged commit 818b9cd into api-platform:3.2 Mar 19, 2024
39 of 55 checks passed
@soyuka
Copy link
Member

soyuka commented Mar 19, 2024

Thanks! ci failures not related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants