New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsonschema) don't skip remaining multiple union types #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwendolenLynch
force-pushed
the
fix/issues/6212
branch
3 times, most recently
from
March 16, 2024 09:22
9c8b786
to
a4b7971
Compare
vincentchalamon
requested changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Minor fixes. Need to fix the CI, then LGTM
GwendolenLynch
force-pushed
the
fix/issues/6212
branch
from
March 19, 2024 13:11
a4b7971
to
2fdedea
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
GwendolenLynch
force-pushed
the
fix/issues/6212
branch
from
March 19, 2024 14:19
2fdedea
to
800c5bd
Compare
GwendolenLynch
force-pushed
the
fix/issues/6212
branch
2 times, most recently
from
March 19, 2024 15:02
59a21da
to
d4b25ec
Compare
GwendolenLynch
force-pushed
the
fix/issues/6212
branch
from
March 19, 2024 15:11
d4b25ec
to
f93036b
Compare
vincentchalamon
approved these changes
Mar 19, 2024
GwendolenLynch
force-pushed
the
fix/issues/6212
branch
2 times, most recently
from
March 19, 2024 15:47
71b36a5
to
8031dae
Compare
soyuka
reviewed
Mar 19, 2024
GwendolenLynch
force-pushed
the
fix/issues/6212
branch
from
March 19, 2024 16:16
8031dae
to
bfdea8c
Compare
Thanks! ci failures not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @soyuka
For the tests I just imported what I had in a sandbox to create the issue. Happy to modify on request.