Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(symfony): no read should throw on wrong uri variables #6357

Merged
merged 1 commit into from May 7, 2024
Merged

fix(symfony): no read should throw on wrong uri variables #6357

merged 1 commit into from May 7, 2024

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented May 7, 2024

fixes #6355

@soyuka soyuka mentioned this pull request May 7, 2024
Closed
@soyuka soyuka merged commit 9d159f4 into api-platform:3.3 May 7, 2024
74 of 76 checks passed
@soyuka soyuka deleted the fix/6355 branch May 7, 2024 16:07
bendavies
bendavies reviewed May 10, 2024
View reviewed changes
features/main/patch.feature
"count": 10
}
"""
Then print last JSON response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this testing anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to change this, #6355 confirmed it worked but I wasn't sure what the behavior should be inside the controller, did a fix at #6368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendavies bendavies bendavies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soyuka @bendavies